Add tests for bot.rules.attachments.#426
Merged
Merged
Conversation
jchristgit
added
a: backend
MarkKoz
added
type: tests
and removed
a: CI
scragly
suggested changes
Sep 17, 2019
MarkKoz
approved these changes
Sep 18, 2019
jchristgit
force-pushed
the
bot-rules-attachments-tests
branch
2 times, most recently
from
a632c71 to
f8e2b17
Compare
scragly
approved these changes
Sep 18, 2019
This also fixes an issue with the `attachments` rule not respecting the most recent message sent by a user.
jchristgit
force-pushed
the
bot-rules-attachments-tests
branch
from
f8e2b17 to
7f70a4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes an issue with the
attachmentsrule not respecting the most recent message sent by a user.